Conversation
Contributor
Author
|
/backport to stable28 |
4 tasks
skjnldsv
approved these changes
Dec 15, 2023
Altahrim
approved these changes
Dec 15, 2023
9691b35 to
3441852
Compare
3441852 to
aededaf
Compare
…contrast and luma calculation) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
… high contrast themes Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
aededaf to
84123b3
Compare
Contributor
Author
|
Had to skip the test if the base class was run as a test case on its own as - of cause - the |
Contributor
Contributor
Author
Yes and no. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
This adjusts the theming utils for calculating the primary color:
invertTextColorby not simply checking the luma channel of the HSL color but the real color contrastAlso keep blurry background and hover states in mind while calculating the element color.
Moreover I added a unit test for accessible colors.
Screenshots
Only the hover state has changed:
Checklist