fix(UnifiedSearch): Remove title prop from modal#42183
Merged
Conversation
Contributor
Author
|
/backport to stable28 |
nfebe
approved these changes
Dec 12, 2023
susnux
force-pushed
the
fix/unified-search-prop
branch
from
5f24a73 to
4da5bba
Compare
Contributor
Author
|
/compile |
artonge
approved these changes
Dec 13, 2023
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/unified-search-prop
branch
from
4da5bba to
a6360d4
Compare
emoral435
approved these changes
Dec 13, 2023
Contributor
Author
|
drone unrelated |
Contributor
|
/backport to stable28 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
titleprop was renamed tonameand is already provided, so thetitleprop is now the nativetitleattribute which we should not set on the modal wrapper as it has no semantically meaning there.Checklist