fix(caldav): don't reuse query builder objects#42144
Merged
miaulalala merged 1 commit intomasterfrom Dec 11, 2023
Merged
Conversation
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
requested review from
ChristophWurst and
tcitworld
as code owners
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/backport to stable27 |
Contributor
Author
|
/backport to stable26 |
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Makes sense!
What I find suspicious is that this is described as a regression, like the feature broke recently. But the QB recyling has happened since the feature was added in 30d13bb.
Member
|
7f0a54c only logs a warning but doesn't abort. |
tcitworld
approved these changes
Dec 11, 2023
Member
|
Yeah, I think it's unlikely this will fix #42143, but they can try to apply the simple patch. |
ChristophWurst
approved these changes
Dec 11, 2023
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Fine by me but won't help with #42143
This was referenced Dec 11, 2023
|
Hi, I've patched my NC28.0.0 because I have the issue #42143 . I confirm the issue is NOT solved by this commit. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reusing query builder objects causes a
Doctrine\DBAL\Query\QueryExceptionTODO
Checklist
Screenshots before/after for front-end changesDocumentation (manuals or wiki) has been updated or is not required