enh(oauth2): allowed toggling of aria label

[emoral435]

• Resolves: [BITV] 9.1.1.1a/10.1 - In the "OAuth 2.0 clients" table, there is a button labeled "Show client secret." This button consistently displays the same alt text regardless of whether the "client secret" has been revealed or hidden. (1) #41824

Summary

The button in the table for OAuth 2.0 previously only had the aria label of "Show client secret", even when the button had toggled the rendering of the client secret. Switched aria label to "Hide client secret" when the rendered secret is visible!

TODO

• add a way to toggle between the states and correctly assign the aria label

Images

Before	After
	(

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[emoral435]

/compile /

[emoral435]

/backport to stable28

added computed value for a constant string for community translators to work with 💖

[emoral435]

/compile /

[ShGKme]

The icon on this button also has a fixed title.

:title="t('oauth2', 'Show client secret')"

Using title on a span is not correct, it should be on the button and it has same dynamic value with "Hide".

But in this case, I think we can just remove the title attr here.

[emoral435]

nice catch! gonna delete that part and then submit the new version : )

[emoral435]

/compile /

[ShGKme]

Works and seems fine now

[emoral435]

@Pytal removed all comments 👍, agree with Grigorii that the name itself is self explanatory!

[ShGKme]

It should have been catched by linter...