Conversation
nfebe
force-pushed
the
share-flow-improvments
branch
from
3f7fd70 to
2e21938
Compare
Accessing `this.$refs.shareList` outside $nextTick() could lead to the holder (`listComponent`) being undefined as the ref is yet to exist. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
It's important to delete the `newPassword` prop from the share model, if the user unchecks the isPasswordProtected checkbox. This clearer and allows for the unchecking to actually work as `this.$set()` fails with the falsy value `''`. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe
force-pushed
the
share-flow-improvments
branch
from
2e21938 to
e73a549
Compare
nfebe
added
3. to review
Contributor
Author
|
/compile |
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/backport to stable27 |
nfebe
changed the title
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzinger
approved these changes
Dec 6, 2023
susnux
approved these changes
Dec 6, 2023
artonge
reviewed
Dec 7, 2023
Contributor
There was a problem hiding this comment.
I think you removed some opening parenthesis and curly brace without removing their closing peer.
Contributor
Author
There was a problem hiding this comment.
Hi @artonge , please can you highlight the particular snippet? I can follow up with another PR, if need be.
8 tasks
Member
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing
this.$refs.shareListoutside $nextTick() could lead to the holder (listComponent) being undefined as the ref is yet to exist.