enh(NavigationManager): Use ID as fallback for app property of entries#42055
Merged
nickvergessen merged 1 commit intomasterfrom Dec 7, 2023
Merged
enh(NavigationManager): Use ID as fallback for app property of entries#42055nickvergessen merged 1 commit intomasterfrom
app property of entries#42055nickvergessen merged 1 commit intomasterfrom
Conversation
susnux
added
enhancement
3. to review
susnux
requested review from
come-nc,
juliusknorr,
max-nextcloud and
nickvergessen
Contributor
Author
|
/backport to stable28 |
nickvergessen
approved these changes
Dec 6, 2023
juliusknorr
approved these changes
Dec 6, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
enh/navigation-manager-set-app-from-id
branch
from
ecd3fad to
b1fffb0
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some apps like Talk do not use the appinfo for registering the navigation entries but using the NavigationManager directly. Those apps do not always set the app property of the navigation entry, in this cases it is currently not possible to use that entry for the default app.
To fix 99% of the cases the ID is now checked to be a valid and enabled app and if yes then use it as fallback.
Checklist