Conversation
jancborchardt
approved these changes
Nov 20, 2023
Member
jancborchardt
left a comment
There was a problem hiding this comment.
Looks good from the videos, thanks! :)
JuliaKirschenheuter
approved these changes
Nov 20, 2023
753e8f3 to
59f183b
Compare
Contributor
Author
|
Updates:
|
nimishavijay
approved these changes
Nov 20, 2023
Member
nimishavijay
left a comment
There was a problem hiding this comment.
Nice! Looks great design-wise!
marcoambrosini
approved these changes
Nov 20, 2023
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
…omponent - Special attribute `is` is deprecated and removed in Vue 3 - It is confusing, that `<a>` element is rendered as `span` sometimes Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
59f183b to
c90ae20
Compare
Contributor
Author
|
Rebased onto master. |
Contributor
Author
|
/backport to stable28 |
|
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Contributor
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There is an outline on
focus-visiblestate, which appears also on click making a glitch effect.At the same time,
focus-visiblestate was not useful because the link was not focusable.Todo
tabindex(links usually should not be focusable, but in this case it works close to the button)linkTo: replace deprecatedisattr on<a>with a dynamic component:isis deprecated and removed in Vue 3<a>element is rendered as<span>sometimesChecklist