feat(search): allow contacts person search

[hamza221]

• Resolves: 🔎 Allow contact and manager search in advanced search contacts#3608

Summary

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[ChristophWurst]

Likely unrelated to your changes but I ran into OCA\DAV\Search\ContactsSearchProvider::getDavUrlForContact(): Argument #1 ($principalUri) must be of type string, null given. This happens when $contactRow is a system contact. $addressBooksById does not contain the SAB for me.

There must be a discrepancy between \OCA\DAV\CardDAV\CardDavBackend::getAddressBooksForUser and \OCA\DAV\CardDAV\CardDavBackend::searchPrincipalUri. The former doesn't return the SAB, the latter searches in it.

[ChristophWurst]

@hamza221 how do I best test this? still the curl curl -u admin:admin -k -H "accept: application/json" "https://localhost/ocs/v2.php/search/providers/contacts/search?term=AAAA&person=nc-user_admin"?

[hamza221]

@hamza221 how do I best test this? still the curl curl -u admin:admin -k -H "accept: application/json" "https://localhost/ocs/v2.php/search/providers/contacts/search?term=AAAA&person=nc-user_admin"?

yes that's how I tested

[ChristophWurst]

@hamza221 set an avatar for your test user then you will run into #41457 (comment) too 🙊

[ChristophWurst]

The db query is wrong. There is a big OR at the top level that circumvents the scoping to address books

SELECT
  DISTINCT `cp`.`cardid`
FROM
  `*PREFIX*cards_properties` `cp`
WHERE
  (
    (
      (`cp`.`addressbookid` = :dcValue1)
      OR (`cp`.`addressbookid` = :dcValue2)
      OR (`cp`.`addressbookid` = :dcValue3)
      OR (`cp`.`addressbookid` = :dcValue4)
      OR (`cp`.`addressbookid` = :dcValue5)
    )
    AND (`cp`.`name` IN (:dcValue6))
    AND (
      `cp`.`value` COLLATE utf8mb4_general_ci LIKE :dcValue7
    )
  )
  OR (
    `cp`.`value` COLLATE utf8mb4_general_ci LIKE :dcValue8
  )
LIMIT
  5

[ChristophWurst]

Suggested change

	$query2->orWhere($query2->expr()->ilike('cp.value', $query2->createNamedParameter('%' . $this->db->escapeLikeParameter($options['person']) . '%')));
	$query2->andWhere($query2->expr()->ilike('cp.value', $query2->createNamedParameter('%' . $this->db->escapeLikeParameter($options['person']) . '%')));

to fix #41457 (comment)

[ChristophWurst]

With this change the feature works as expected for me. If there is a regular contact with the same name as the filtered user, I will see the contact. If there is no match, I see nothing 👍

[ChristophWurst]

Works 🚀

[jospoortvliet]

whooot somebody is going to hit that merge button!!!!

/me holds breath

[ChristophWurst]

Some actions fail. But it's not the job/checks that fail but the runner.