Conversation
marcoambrosini
commented
Nov 14, 2023
marcoambrosini
commented
- partially fixes --> Beta design feedback #41450
marcoambrosini
requested review from
a team,
emoral435,
jancborchardt,
nickvergessen,
skjnldsv and
sorbaugh
and removed request for
a team
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks really nice design-wise! Highlights the shared state while not overly distracting from the file name. :)
|
|
||
| <style lang="scss" scoped> | ||
|
|
||
| :deep(.button-vue--icon-and-text, .files-list__row-action-sharing-status) { |
There was a problem hiding this comment.
This means one of the libraries has an issue?
Do all apps that use the filepicker from nextcloud/dialogs need to cheat like this?
There was a problem hiding this comment.
Sorry, In the rush of those days I missed this comment.
No: this whole set of changes were temporary hacks for files screenshots sake and a less than ideal solutions. I wouldn't have wanted to replicate them in other places.
We talked about using two columns for owner and shared status and doing this properly in the near future.
AndyScherzinger
added
design
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
Looks good to me, as we need to get this done by EOD, this maybe can be improved but for now it looks good!
emoral435
force-pushed
the
enh/41450/improve-shared-status-button
branch
from
124d00e to
28efb51
Compare
susnux
force-pushed
the
enh/41450/improve-shared-status-button
branch
from
28efb51 to
f3f7415
Compare
Signed-off-by: Marco <[email protected]>
susnux
force-pushed
the
enh/41450/improve-shared-status-button
branch
from
f3f7415 to
c2c5994
Compare
|
Super nice! |
7 participants
