feat(dav): dispatch out-of-office started and ended events by st3iny · Pull Request #41440 · nextcloud/server

st3iny · 2023-11-13T16:39:53Z

Resolves: none
Follow-up to Out-of-office: Expose data via OCP/OCS APIs #40650
Required for Out-of-office: Apply user info to auto responder settings (if enabled) mail#8925

Summary

Adds a new queued job that emits events when a out-of-office period of a user begins and ends.

TODO

Test using the integration in Mail
Deal with time zones

How to smoke test

Open the availability settings page
Enter out of office data
Save
Look into the oc_jobs database table, find the job for class \OCA\DAV\BackgroundJob\OutOfOfficeEventDispatcherJob, note its id
Run php occ background-job:execute <id> --force-execute

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

apps/dav/lib/BackgroundJob/OutOfOfficeEventDispatcherJob.php

apps/dav/lib/Controller/AvailabilitySettingsController.php

ChristophWurst

Looks good! We'll need the user timezone to dispatch this at the correct time

apps/dav/lib/BackgroundJob/OutOfOfficeEventDispatcherJob.php

ChristophWurst · 2023-11-23T09:44:58Z

Deal with time zones

I'm looking into this now

ChristophWurst · 2023-11-23T11:01:11Z

TZ handling based on a cleaned-up version of #41461 added. It's a bit messy to have to fetch the current timezone setting everywhere, OTOH this allows the tz to move with the user, should it ever change.

Tests will need adjustment. Looking into that shortly.

apps/dav/lib/Db/PropertyMapper.php

apps/dav/lib/Db/Property.php

+ * @method string getPropertyname()
+ * @method string getPropertyvalue()
+ */
+class Property extends Entity {


apps/dav/lib/Db/Property.php

ChristophWurst · 2023-11-23T14:35:03Z

Psalm and tests should be happy now

ChristophWurst

For @st3iny's part

apps/dav/lib/BackgroundJob/OutOfOfficeEventDispatcherJob.php

+		parent::__construct($time);
+	}
+
+	public function run($argument): void {


Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

st3iny

✔️ for Christoph's part. There still is a off-by-one bug that will be fixed in a follow-up.

ChristophWurst · 2023-11-24T06:19:51Z

Merging because the 28 backport is in too

st3iny added enhancement 2. developing Work in progress labels Nov 13, 2023

st3iny added this to the Nextcloud 28 milestone Nov 13, 2023

st3iny self-assigned this Nov 13, 2023

ChristophWurst reviewed Nov 13, 2023

View reviewed changes

apps/dav/lib/BackgroundJob/OutOfOfficeEventDispatcherJob.php Show resolved Hide resolved

apps/dav/lib/BackgroundJob/OutOfOfficeEventDispatcherJob.php Show resolved Hide resolved

apps/dav/lib/BackgroundJob/OutOfOfficeEventDispatcherJob.php Show resolved Hide resolved

github-advanced-security bot found potential problems Nov 13, 2023

View reviewed changes

This was referenced Nov 14, 2023

28.0.0 beta 3 #41379

Merged

28.0.0 beta 4 #41477

Merged

ChristophWurst requested review from ChristophWurst and miaulalala November 15, 2023 13:52

ChristophWurst reviewed Nov 15, 2023

View reviewed changes

blizzz mentioned this pull request Nov 20, 2023

28.0.0 RC1 #41621

Merged

5 tasks

st3iny mentioned this pull request Nov 20, 2023

feat: apply personal out-of-office data to the auto responder nextcloud/mail#9077

Merged

2 tasks

st3iny force-pushed the feat/dav/out-of-office-job branch from 66c089d to 1f3ef66 Compare November 21, 2023 17:41

github-advanced-security bot found potential problems Nov 21, 2023

View reviewed changes

apps/dav/lib/BackgroundJob/OutOfOfficeEventDispatcherJob.php Fixed Show fixed Hide fixed

apps/dav/lib/BackgroundJob/OutOfOfficeEventDispatcherJob.php Fixed Show fixed Hide fixed

blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023

github-advanced-security bot found potential problems Nov 23, 2023

View reviewed changes

backportbot-nextcloud bot added the backport-request label Nov 23, 2023

ChristophWurst marked this pull request as ready for review November 23, 2023 14:41

ChristophWurst requested a review from tcitworld as a code owner November 23, 2023 14:41

ChristophWurst added 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update and removed 2. developing Work in progress labels Nov 23, 2023

ChristophWurst approved these changes Nov 23, 2023

View reviewed changes

ChristophWurst self-assigned this Nov 23, 2023

github-advanced-security bot found potential problems Nov 23, 2023

View reviewed changes

apps/dav/lib/BackgroundJob/OutOfOfficeEventDispatcherJob.php

parent::__construct($time);

}

public function run($argument): void {

Check notice

Code scanning / Psalm

MissingParamType

Parameter $argument has no provided type

feat(dav): dispatch out-of-office started and ended events

8191295

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

st3iny commented Nov 23, 2023

View reviewed changes

ChristophWurst force-pushed the feat/dav/out-of-office-job branch from ea0dbb4 to 8191295 Compare November 23, 2023 16:19

This was referenced Nov 23, 2023

[stable28] feat(dav): dispatch out-of-office started and ended events #41701

Merged

fix(dav): Convert dates without tz drift #41703

Merged

ChristophWurst merged commit eeba809 into master Nov 24, 2023

ChristophWurst deleted the feat/dav/out-of-office-job branch November 24, 2023 06:20

ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Nov 24, 2023

ChristophWurst mentioned this pull request Nov 24, 2023

enh(userstatus): add OOO automation and remove calendar automation #41714

Merged

5 tasks

st3iny removed the backport-request label Dec 4, 2023

ChristophWurst mentioned this pull request Dec 5, 2023

Out of office docs for admins nextcloud/documentation#11332

Closed

blizzz mentioned this pull request Mar 5, 2024

29.0.0 beta 1 #43991

Merged

Uh oh!

Conversation

st3iny commented Nov 13, 2023 • edited by ChristophWurst Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

How to smoke test

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ChristophWurst commented Nov 23, 2023

Uh oh!

ChristophWurst commented Nov 23, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check notice

Uh oh!

ChristophWurst commented Nov 23, 2023

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

Check notice

st3iny left a comment

Choose a reason for hiding this comment

Uh oh!

ChristophWurst commented Nov 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

st3iny commented Nov 13, 2023 •

edited by ChristophWurst

Loading