fix(log): Log exception class when message is empty#41406
Merged
nickvergessen merged 1 commit intomasterfrom Nov 13, 2023
Merged
fix(log): Log exception class when message is empty#41406nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
tcitworld
approved these changes
Nov 13, 2023
Member
tcitworld
left a comment
There was a problem hiding this comment.
Maybe add an "Exception thrown:" prefix for context?
Merged
ChristophWurst
approved these changes
Nov 13, 2023
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
Can we also find out where an empty log message is logged?
Member
Author
The error from production was in logged via this: Line 81 in bb2c2bb |
Signed-off-by: Joas Schilling <[email protected]>
78915b9 to
a5684ea
Compare
Member
Author
|
Added the prefix |
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist