fix(events): Make sure all \OCP\Files::… events are emitted with th…

[nickvergessen]

…e same data

• Resolves: [Bug]: OCA\WorkflowEngine\Entity\File::getNode(): Return value must be of type OCP\Files\Node, array returned #41360

Summary

• Make sure the events in appdata match the ones for normal files

  server/lib/private/Files/Node/HookConnector.php

  Lines 122 to 126 in 44a0a62

  	$node = $this->getNodeForPath($arguments['path']);
  	$this->root->emit('\OC\Files', 'postCreate', [$node]);
  	$this->dispatcher->dispatch('\OCP\Files::postCreate', new GenericEvent($node));
  	$event = new NodeCreatedEvent($node);

• This was always misaligned, but in 27 etc the event was dispatched with 2 different classes and therefore the type check at

  server/apps/workflowengine/lib/AppInfo/Application.php

  Lines 103 to 114 in efb7448

  	} else {
  	$logger->debug(
  	'Cannot handle event {name} of {event} against entity {entity} and operation {operation}',
  	[
  	'app' => self::APP_ID,
  	'name' => $eventName,
  	'event' => get_class($event),
  	'entity' => $entityClass,
  	'operation' => $operationClass,
  	]
  	);
  	}

  checked a wrong event so it was actually never handled and did not error:
  • HookConnector used OCP\EventDispatcher\GenericEvent

  • server/lib/private/Files/Node/HookConnector.php

    Line 31 in 6034cc6

    use OCP\EventDispatcher\GenericEvent;

  • Node::sendHooks used Symfony\Component\EventDispatcher\GenericEvent

  • server/lib/private/Files/Node/Node.php

    Line 43 in f724760

    use Symfony\Component\EventDispatcher\GenericEvent;

• So the same event was emitted with 2 different event classes and 2 different sets of parameters.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nickvergessen]

I guess we might want to backport this, but then we also need to backport the transition to OCP\EventDispatcher\GenericEvent to have it half broken

[nickvergessen]

Follow up to backport #41404