feat(files): quota warning and disabled upload button#41346
Merged
Conversation
8 tasks
e15eaf2 to
83f04b0
Compare
Merged
susnux
approved these changes
Nov 9, 2023
Merged
emoral435
approved these changes
Nov 14, 2023
Contributor
emoral435
left a comment
There was a problem hiding this comment.
Really liked these changes. Only comment would be if there is any way there is any way that there is less than 0 free storage space, the strict comparison with " === 0 " might not pass, and " <= 0" might be better.
But if not, I really liked the changes committed here!
Member
Author
|
/backport to stable28 |
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Member
Author
|
Signed-off-by: John Molakvoæ <[email protected]>
83f04b0 to
f89ef39
Compare
Member
Author
|
|
This was referenced Jan 5, 2024
Member
Author
|
/backport in #42591 |
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing from F2V
Fix #41113
Fix #41020
Quota warning
> 0to0This will prevent spamming with notifications and still warn people on sudden change
Upload button
This PR also fixes the Upload button not being disabled on quota exceeded

Upload error handling
Last commit also adds some better error handling
Unfortunately most of the server error messages remains untranslated, so we will use our own, despite the server potentially providing a bit more context.
but we can still merge already. This will automatically works on the next dependency update
Example:
Versus