fix(dav): multiple fixes in usage of webdav library#41202
Merged
Conversation
Member
pulsejet
commented
Oct 30, 2023
pulsejet
commented
- Refresh token on update
- Fix some very weird imports
- Patch fetch instead of request to prevent accessing impl details
pulsejet
commented
Oct 30, 2023
pulsejet
added a commit
to pulsejet/nextcloud-files
that referenced
this pull request
Oct 30, 2023
nextcloud/server#41202 Signed-off-by: Varun Patil <[email protected]>
Member
Can you clarify what is this about? :) |
pulsejet
added a commit
to pulsejet/nextcloud-files
that referenced
this pull request
Oct 31, 2023
nextcloud/server#41202 Signed-off-by: Varun Patil <[email protected]>
pulsejet
added a commit
to pulsejet/nextcloud-files
that referenced
this pull request
Oct 31, 2023
nextcloud/server#41202 Signed-off-by: Varun Patil <[email protected]>
pulsejet
force-pushed
the
pulsejet/fix-webdav
branch
2 times, most recently
from
3a50a40 to
59c544c
Compare
Member
Author
To patch import { request } from 'webdav/dist/node/request.js'This is an implementation detail of the webdav library and also needs the node polyfills. Instead we can just patch BTW, fixed the style to align with nextcloud-files |
Merged
artonge
approved these changes
Nov 2, 2023
skjnldsv
approved these changes
Nov 3, 2023
Member
Author
|
I want to point out that things might be broken without this patch in 28. When the refresh token changes, the WebDAV clients are never updated in RC.1 This is not a feature, it's a fix to a regression. |
pulsejet
force-pushed
the
pulsejet/fix-webdav
branch
from
59c544c to
3422780
Compare
pulsejet
force-pushed
the
pulsejet/fix-webdav
branch
from
3422780 to
0b0ea51
Compare
Member
Author
|
/compile amend / |
pulsejet
force-pushed
the
pulsejet/fix-webdav
branch
4 times, most recently
from
a8cde62 to
410bddd
Compare
Member
Author
|
CI failure seems unrelated |
1. Refresh token on update 2. Fix some very weird imports 3. Patch fetch instead of request to prevent accessing impl details Signed-off-by: Varun Patil <[email protected]>
skjnldsv
force-pushed
the
pulsejet/fix-webdav
branch
from
410bddd to
b03fd6e
Compare
skjnldsv
added
4. to release
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.