Closed
Conversation
nickvergessen
previously requested changes
Oct 31, 2023
Member
|
Setting
pending documentation
|
Contributor
Author
|
Thanks for pointing it out! For context, the comments feature is being moved to the activity repo, so this is one of two pull requests. |
Merged
eebbf87 to
224e8eb
Compare
2 tasks
artonge
approved these changes
Nov 2, 2023
artonge
reviewed
Nov 2, 2023
Contributor
There was a problem hiding this comment.
What was the use of this file?
artonge
requested changes
Nov 2, 2023
Member
|
That also means we can keep the public API working for apps using the comments UI, that's great news! |
Merged
Contributor
|
closing in favor of #41491 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the the second part of a two part Pull Request to move code from the comments app found in server to the activity app.
Here is the other PR: nextcloud/activity#1387
Checklist