Respect custom webroot in setup form#41189
Merged
skjnldsv merged 1 commit intonextcloud:masterfrom Mar 14, 2024
Merged
Conversation
susnux
requested review from
a team,
come-nc,
icewind1991 and
skjnldsv
and removed request for
a team
kesselb
requested changes
Oct 30, 2023
kesselb
reviewed
Oct 30, 2023
HolonProduction
force-pushed
the
webroot-setup
branch
from
d9a6184 to
a36388e
Compare
skjnldsv
approved these changes
Oct 31, 2023
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Code make sense and worked for me
Merged
kesselb
approved these changes
Mar 8, 2024
icewind1991
force-pushed
the
webroot-setup
branch
from
a36388e to
23d1b45
Compare
Merged
Collaborator
|
@HolonProduction CI failures seems unrelated. |
HolonProduction
force-pushed
the
webroot-setup
branch
2 times, most recently
from
23d1b45 to
13352ca
Compare
Contributor
Author
|
Done |
Signed-off-by: HolonProduction <holonproduction@gmail.com>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passes an url generator to the installation template and uses it to generate an absoluteUrl.