Conversation
|
@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @Xenopathic and @LukasReschke to be potential reviewers. |
|
Any chance we can keep the dragons contained in their own app? |
|
@icewind1991 i caught one dragon for you: on mkdir('foo/bar') an opendir against 'foo' is performed. why? So, the scanner kicks in (external storage), but it is necessary when triggered by httpMkcol()? The direct trigger is getNodeForPath() from our ObjectTree Connector. At this point however there is no information about the operation. Hm. |
Codecov Report
@@ Coverage Diff @@
## master #4106 +/- ##
============================================
- Coverage 54.2% 53.76% -0.45%
- Complexity 21597 21838 +241
============================================
Files 1327 1277 -50
Lines 82538 76276 -6262
Branches 1305 0 -1305
============================================
- Hits 44739 41007 -3732
+ Misses 37799 35269 -2530
|
a73b031 to
1036364
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* use NTLM Login only for now * fix fetching Document Library * fix retrieve root folder info Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
also simplifies and improves internal fetchFileOrFolder method Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* seperates direct backend code and API handling * an awful lot easier to unit test Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
it appears awefully slow, mostly because of yet missing caching, as other storage backends deal with that. To be added later. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
still takes too long though Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
depending on whether a . is present in the path, with fallback. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* look for hidden info only when really necessary * also on for folders * don't retrieve folder contents not with fetchFolder, fetchFolderContents only Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
saves re-requesting any of its childeren from SP Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
includes performance optimization for this and mkdir Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
1036364 to
9b79ddb
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
deprecates nextcloud/server#4106 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
|
After some off-github discussions, this is deprecated in favor of a separate app → https://github.com/nextcloud/sharepoint |
Contributes to #2672
Add a SharePoint Backend to files_external
configuration:
requirements
environment
features