Skip to content

SharePoint support#4106

Closed
blizzz wants to merge 32 commits intomasterfrom
sharepoint-support
Closed

SharePoint support#4106
blizzz wants to merge 32 commits intomasterfrom
sharepoint-support

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Mar 27, 2017

Contributes to #2672

Add a SharePoint Backend to files_external

configuration:

spectacle k24324

requirements

  • NTLM Auth enabled on SP. We strictly require NTLM Auth. Basic did not work for me, I assume because of the SP/IIS configuration. Apparently NTLM is > then Basic anyhow.

environment

features

  • dir listings, trying to identify and hide hidden system directories (e.g. "Forms").
  • creating dirs
  • down- and upload of files (via streams, exception: new files)
  • renames
  • removing files and folders (using recycle method i.e. putting it into the wastebin)
  • determine CRUD permissions

@blizzz blizzz added this to the Nextcloud 12.0 milestone Mar 27, 2017
@mention-bot
Copy link

@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @Xenopathic and @LukasReschke to be potential reviewers.

@nickvergessen nickvergessen mentioned this pull request Mar 27, 2017
59 tasks
@icewind1991
Copy link
Member

Any chance we can keep the dragons contained in their own app?

@blizzz
Copy link
Member Author

blizzz commented Mar 28, 2017

@icewind1991 i caught one dragon for you: on mkdir('foo/bar') an opendir against 'foo' is performed. why?

So, the scanner kicks in (external storage), but it is necessary when triggered by httpMkcol()? The direct trigger is getNodeForPath() from our ObjectTree Connector. At this point however there is no information about the operation. Hm.

@codecov-io
Copy link

codecov-io commented Mar 28, 2017

Codecov Report

Merging #4106 into master will decrease coverage by 0.44%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4106      +/-   ##
============================================
- Coverage      54.2%   53.76%   -0.45%     
- Complexity    21597    21838     +241     
============================================
  Files          1327     1277      -50     
  Lines         82538    76276    -6262     
  Branches       1305        0    -1305     
============================================
- Hits          44739    41007    -3732     
+ Misses        37799    35269    -2530
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/DAV/Sharing/Backend.php 71.08% <0%> (-16.87%) 17% <0%> (ø)
apps/sharebymail/lib/Settings/SettingsManager.php 25% <0%> (-15%) 3% <0%> (+1%)
apps/user_ldap/appinfo/routes.php 66.66% <0%> (-10.61%) 0% <0%> (ø)
apps/sharebymail/lib/ShareByMailProvider.php 60.07% <0%> (-8.68%) 87% <0%> (+22%)
apps/comments/lib/EventHandler.php 79.16% <0%> (-8.34%) 7% <0%> (ø)
settings/Controller/CheckSetupController.php 70.52% <0%> (-8.1%) 56% <0%> (ø)
apps/dav/lib/CalDAV/Calendar.php 73.68% <0%> (-3.42%) 52% <0%> (+3%)
apps/user_ldap/lib/User/User.php 80.53% <0%> (-2.15%) 123% <0%> (+32%)
apps/dav/lib/CardDAV/AddressBook.php 64.63% <0%> (-2.04%) 27% <0%> (+3%)
apps/user_ldap/lib/User_LDAP.php 74.35% <0%> (-1.54%) 72% <0%> (+3%)
... and 186 more

@blizzz blizzz force-pushed the sharepoint-support branch from a73b031 to 1036364 Compare March 31, 2017 10:12
blizzz added 20 commits April 4, 2017 12:25
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* use NTLM Login only for now
* fix fetching Document Library
* fix retrieve root folder info

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
also simplifies and improves internal fetchFileOrFolder method

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* seperates direct backend code and API handling
* an awful lot easier to unit test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
it appears awefully slow, mostly because of yet missing caching,
as other storage backends deal with that. To be added later.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
still takes too long though

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
depending on whether a . is present in the path, with fallback.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* look for hidden info only when really necessary
* also on for folders
* don't retrieve folder contents not with fetchFolder,
fetchFolderContents only

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz added 5 commits April 4, 2017 12:25
saves re-requesting any of its childeren from SP

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
includes performance optimization for this and mkdir

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the sharepoint-support branch from 1036364 to 9b79ddb Compare April 19, 2017 22:16
blizzz added 6 commits April 20, 2017 13:16
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz changed the title [WIP] SharePoint support SharePoint support Apr 24, 2017
@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 24, 2017
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz added a commit to nextcloud/sharepoint that referenced this pull request Apr 26, 2017
deprecates nextcloud/server#4106

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
Copy link
Member Author

blizzz commented Apr 26, 2017

After some off-github discussions, this is deprecated in favor of a separate app → https://github.com/nextcloud/sharepoint

@blizzz blizzz closed this Apr 26, 2017
@MorrisJobke MorrisJobke deleted the sharepoint-support branch April 26, 2017 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants