Merged
Conversation
Member
Author
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
15cdbe8 to
c89df97
Compare
7ab7aaa to
1cbbe62
Compare
1cbbe62 to
915577d
Compare
29 tasks
1b13b8e to
683ef89
Compare
9ab9645 to
76faa13
Compare
Merged
1065e8a to
2fc9ba3
Compare
Merged
7205ff1 to
f497d8b
Compare
26f0d4d to
15688f6
Compare
come-nc
reviewed
Jan 4, 2024
come-nc
approved these changes
Jan 4, 2024
skjnldsv
approved these changes
Jan 4, 2024
0ca5f48 to
52edf28
Compare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
52edf28 to
4367a5e
Compare
Contributor
|
Is it expected that running Without blurhash: With blurhash: |
Member
Author
|
Yes,
|
Contributor
|
3 times with blurhash: and three times without: Basically only the default media files from julius docker dev (see https://github.com/juliushaertl/nextcloud-docker-dev/tree/master/data/skeleton): |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Catching FilesMetadata's event and when encountering an image file, this will fill metadata with blurhash [1] which is a little string that simulate a placeholder.
Should greatly improve loading smoothness when displaying gallery of pictures
If you want to test:
./occ metadata:get <file_id>[1] https://blurha.sh/