Updated visible 'Twitter' name to 'X' in Personal info#41041
Updated visible 'Twitter' name to 'X' in Personal info#41041AndyScherzinger merged 2 commits intonextcloud:masterfrom
Conversation
a595ab1 to
fda0c3c
Compare
| <template> | ||
| <AccountPropertySection v-bind.sync="twitter" | ||
| :placeholder="t('settings', 'Your Twitter handle')" /> | ||
| :placeholder="t('settings', 'Your X handle')" /> |
There was a problem hiding this comment.
Maybe?
| :placeholder="t('settings', 'Your X handle')" /> | |
| :placeholder="t('settings', 'Your X | |
| (formerly Twitter) handle')" /> |
There was a problem hiding this comment.
Thanks for the suggestion! I've updated the PR.
| PROFILE_ENABLED: t('settings', 'Profile'), | ||
| ROLE: t('settings', 'Role'), | ||
| TWITTER: t('settings', 'Twitter'), | ||
| TWITTER: t('settings', 'X (Formerly Twitter)'), |
There was a problem hiding this comment.
| TWITTER: t('settings', 'X (Formerly Twitter)'), | |
| TWITTER: t('settings', 'X (formerly Twitter)'), |
There was a problem hiding this comment.
Thanks for the suggestion! I've updated the PR.
9a7cc39 to
f0f1e49
Compare
|
Sorry, this is my first time contributing to this project and I'm a bit confused. What are the next steps for getting this PR merged in? Also, I have a few questions:
If anyone can help answer these questions or point me in the right direction, that would be greatly appreciated. Thanks! |
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: George Calderon <gcald117@gmail.com>
Signed-off-by: George Calderon <gcald117@gmail.com>
f0f1e49 to
a047686
Compare
|
/compile / |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Merged via #41385 Thanks a lot for the PR @gcald To answer your questions
Yes the dist folder needs to be commited
Test failures were not related to your PR, you can view the output at the bottom of PRs on the "Details" link of the failing Github action. |
Summary
Before:
After:
TODO
Checklist