chore(tests): Run all unit tests on GitHub instead of Drone

[susnux]

• Part of Move from Drone to GitHub Actions #41187

Summary

Lets move from drone to GitHub this way we can use our runners more flexible and restart flaky tests separatly instead of "drone unrelated".

TODO

• Do we want to backport this for all branches?
• Make all the phpunit-summary tests required (someone with super powers)

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nickvergessen]

CS complains:

Suggested change

	*/
	*/

[nickvergessen]

But lets see if there is more, before we fix and rebase

[nickvergessen]

No DB tests look suspicious

There were 3 failures:

1) OCA\DAV\Tests\unit\CalDAV\Reminder\NotifierTest::testPrepare with data set #0 ('calendar_reminder', array('Title of this event', '2005-08-15T15:52:01+02:00'), 'Title of this event (in 1 hou...nutes)', array('Title of this event', null, 'NC Headquarters', false, '2005-08-15T15:52:01+02:00', false, 'Europe/Berlin', '2005-08-15T17:52:01+02:00', false, 'Europe/Berlin', 'Personal'), 'Calendar: Personal\r\nDate: 2...arters')
Expectation failed for method name is "setParsedSubject" when invoked 1 time(s)
Parameter 0 for invocation OCP\Notification\INotification::setParsedSubject('Title of this event'): OCP\Notification\INotification does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Title of this event (in 1 hour, 52 minutes)'
+'Title of this event'

/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Notifier.php:186
/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Notifier.php:133
/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Notifier.php:116
/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/CalDAV/Reminder/NotifierTest.php:244

2) OCA\DAV\Tests\unit\CalDAV\Reminder\NotifierTest::testPrepare with data set #1 ('calendar_reminder', array('Title of this event', '2005-08-15T13:00:00+02:00'), 'Title of this event (1 hour ago)', array('Title of this event', null, 'NC Headquarters', false, '2005-08-15T13:00:00+02:00', false, 'Europe/Berlin', '2005-08-15T15:00:00+02:00', false, 'Europe/Berlin', 'Personal'), 'Calendar: Personal\r\nDate: 2...arters')
Expectation failed for method name is "setParsedSubject" when invoked 1 time(s)
Parameter 0 for invocation OCP\Notification\INotification::setParsedSubject('Title of this event'): OCP\Notification\INotification does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Title of this event (1 hour ago)'
+'Title of this event'

/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Notifier.php:186
/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Notifier.php:133
/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Notifier.php:116
/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/CalDAV/Reminder/NotifierTest.php:244

3) OCA\DAV\Tests\unit\CalDAV\Reminder\NotifierTest::testPassedEvent
Expectation failed for method name is "setParsedSubject" when invoked 1 time(s)
Parameter 0 for invocation OCP\Notification\INotification::setParsedSubject('Title of this event'): OCP\Notification\INotification does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Title of this event (6 hours ago)'
+'Title of this event'

/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Notifier.php:186
/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Notifier.php:133
/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Notifier.php:116
/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/CalDAV/Reminder/NotifierTest.php:289

[nickvergessen]

Okay we are running into $this->hasPhpDatetimeDiffBug()

server/apps/dav/lib/CalDAV/Reminder/Notifier.php

Lines 173 to 184 in 08b4302

	if (count($components) > 0 && !$this->hasPhpDatetimeDiffBug()) {
	// Limiting to the first three components to prevent
	// the string from getting too long
	$firstThreeComponents = array_slice($components, 0, 2);
	$diffLabel = implode(', ', $firstThreeComponents);
	if ($diff->invert) {
	$title = $this->l10n->t('%s (in %s)', [$title, $diffLabel]);
	} else {
	$title = $this->l10n->t('%s (%s ago)', [$title, $diffLabel]);
	}
	}

php/php-src#9699 (comment)

Now fixed, for PHP 8.1.14 and PHP 8.2.1.

[nickvergessen]

Our runtime is:

Runtime: PHP 8.1.2-1ubuntu2.13

[szaimen]

🎉🎉🎉🎉🎉

[nickvergessen]

Hmpf it merged with red ci.... was not good to enable automerge I guess..

But it's so weird, I extracted the failing S3 test in #43154 and it passes there...