fix(xhr-request): Make sure to also allow strings as url#40951
Merged
juliusknorr merged 1 commit intomasterfrom Oct 17, 2023
Merged
fix(xhr-request): Make sure to also allow strings as url#40951juliusknorr merged 1 commit intomasterfrom
juliusknorr merged 1 commit intomasterfrom
Conversation
susnux
requested review from
a team,
julien-nc,
juliusknorr,
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
4 tasks
skjnldsv
approved these changes
Oct 17, 2023
Contributor
Author
|
/compile amend |
Member
|
Duplicate of #40944 but yours seems much nicer :) |
juliusknorr
approved these changes
Oct 17, 2023
nextcloud-command
force-pushed
the
fix/xhr-request-regression
branch
from
bcfc1bc to
9f74f6a
Compare
Our utility to add `X-Requested-With` headers on API calls intercepts calls to `window.fetch`, so we must ensure we allow all parameters that the default browser provided `window.fetch` allows. In this case make sure to allow all stringify-able objects. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
force-pushed
the
fix/xhr-request-regression
branch
from
9f74f6a to
0414ca3
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our utility to add
X-Requested-Withheaders on API calls intercepts calls towindow.fetch, so we must ensure we allow all parameters that the default browser providedwindow.fetchallows.In this case make sure to allow all stringifyable objects.
(tests are already included, see failing cypress tests for custom user background on master 😉 )
Checklist