Allow share expiry dates lower than enforced limits#40927
Merged
Conversation
nfebe
force-pushed
the
allow-expiry-dates-less-than-enforced-limit
branch
from
b24b3aa to
39c8762
Compare
susnux
approved these changes
Oct 15, 2023
Previously, users could change the share expiry date up to the enforced maximum. The new share flow imposed the enforced share expiry date maximum literally and did not allow even dates lower than the maximum enforced. That does not make much sense, if the enforced expiry date is 30 days from creation date, then it's logical to allow users set the date to anything less than 30 days from the creation date. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe
force-pushed
the
allow-expiry-dates-less-than-enforced-limit
branch
from
39c8762 to
9757e68
Compare
sorbaugh
approved these changes
Oct 16, 2023
Contributor
|
I tested and I confirm #40928 (review) , this change breaks default date handling for remote and public shares, the default date is use there as a maximum even if enforced checkbox is not checked for those types of shares. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, users could change the share expiry date up to the enforced maximum.
The new share flow imposed the enforced share expiry date maximum literally and did not allow even dates lower than the maximum enforced.
That does not make much sense, if the enforced expiry date is 30 days from creation date, then it's logical to allow users set the date to anything less than 30 days from the creation date.
Resolves : No github issue