Conversation
nickvergessen
added
enhancement
3. to review
|
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @schiessle, @oparoz and @DeepDiver1975 to be potential reviewers |
Member
|
👍 |
1 similar comment
Member
|
👍 |
Member
|
@nickvergessen merge conflicts... please rebase |
Member
Author
nickvergessen
added
2. developing
nickvergessen
force-pushed
the
psr4-theming
branch
from
d99e53e to
eb28934
Compare
Member
Author
|
Rebased, now also fixes #433 and does not use private API anymore. |
nickvergessen
added
3. to review
Member
|
Tested and works 👍 |
Member
|
please let's wait a second until #636 is merged... Rebasing this branch is way easier than the other way arround. |
Member
|
@schiessle Could you resolve the conflicts now? #636 is merged |
MorrisJobke
added
2. developing
Member
|
rebased, let's run the test once more and then merge it |
Member
|
@nickvergessen can you take care of the stable10 backport? Thanks! |
MorrisJobke
added
3. to review
GitHubUser4234
pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
PSR-4 for the Theming app
R0Wi
pushed a commit
to R0Wi/server
that referenced
this pull request
Nov 22, 2025
…iteln-is-string fix(command): Ensure that writeln() argument is string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #433