fix: Show error message when CSRF check fails at login#40799
Merged
ChristophWurst merged 1 commit intomasterfrom Nov 8, 2023
Merged
fix: Show error message when CSRF check fails at login#40799ChristophWurst merged 1 commit intomasterfrom
ChristophWurst merged 1 commit intomasterfrom
Conversation
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
provokateurin
approved these changes
Oct 6, 2023
skjnldsv
approved these changes
Oct 6, 2023
Member
|
I would recommend a message like "Internal checks failed. Please try again.". |
Member
Author
|
Adjusted. I also fixed that the NcNoteCard was used incorrectly. |
miaulalala
approved these changes
Oct 9, 2023
cb08db2 to
129c7b7
Compare
Member
Author
|
/compile amend / |
129c7b7 to
4d0e11e
Compare
Member
Author
|
/rebase |
1fe02f9 to
e7d8876
Compare
Merged
e7d8876 to
269dc52
Compare
Merged
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
269dc52 to
a5422a3
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is also known as the "double login"
How to test
master: you see the same page again, no changes
here: you see the same page again but with an error message
Checklist