fix(OC_Template.php): ensure we throw all errors

[Psycojoker]

Summary

In one branch of the try/catch combination, in one specific path no error was thrown at all, thus the user ended up with a 500 error page online but absolutely no error anyway in the logs.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• [ ] Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• [ ] Backports requested where applicable (ex: critical bugfixes)

[Psycojoker]

Hello,

Do you want unit/other tests for this quick fix? I honestly would have absolutely no idea on how to do them, I have nearly 0 experience in php (and especially not modern php).

Kind regards and thx for this great software ❤️

[kesselb]

If you reach line 316, that means no error occurred while logging the exception.
Are you sure there was nothing in your nextcloud logs?

[Psycojoker]

Are you sure there was nothing in your nextcloud logs?

Yes, I've looked at every possible log imaginable:

• nextcloud.log ofc
• everything possible in /var/log/**/*.log
• all fpm process, activating logs etc...
• every possible related systemd process

Adding those lines was the only possible way to get the logging of the exact error somewhere (the error was that nextcloud couldn't connect to the database because it was stopped)

[kesselb]

I assume we fixed that already for master/28 with #37458.

[Psycojoker]

Maybe it would be a good idea to still have a fallback in the case the logging system broke for whatever reason again?

[susnux]

We no longer use OC_Template and the remaining functions are deprecated as of 32.