Merged
Conversation
skjnldsv
approved these changes
Oct 1, 2023
max-nextcloud
approved these changes
Oct 2, 2023
Contributor
max-nextcloud
left a comment
There was a problem hiding this comment.
Probably also makes sense in node.yml and (less important as only run by chron) npm-audit-fix.yml.
9c8749d to
b24526b
Compare
Contributor
I rebased and added them. |
b24526b to
acd37ac
Compare
susnux
approved these changes
Oct 10, 2023
acd37ac to
30c060a
Compare
Contributor
Author
|
Cypress failure unrelated, please force merge. |
Merged
As per https://github.com/puppeteer/puppeteer#installation Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
30c060a to
67a761b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A eslint job failed last week with:
Similar to cypress there is no need to download chrome to run eslint / cypress / etc.
TODO
Checklist