Closed
Conversation
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Valdnet
added
the
feature: language/translations (l10n/i18n)
rakekniven
approved these changes
Sep 29, 2023
szaimen
approved these changes
Sep 29, 2023
Contributor
|
/compile |
blizzz
requested changes
Sep 29, 2023
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Co-authored-by: Arthur Schiwon <blizzz@arthur-schiwon.de> Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Contributor
|
@Valdnet this needs a manual rebase and then you can run the compile command again |
Member
|
@nickvergessen was my suggestion actually ok, or are there smarter/better ways? perhaps also with RTL in mind? |
| let title = t('files_sharing', 'Share with ') | ||
| let title = t('files_sharing', 'Share with') + " " | ||
| if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_USER) { | ||
| title = title + this.share.shareWithDisplayName |
Member
There was a problem hiding this comment.
As per https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#improving-your-translations this is not good.
It would be better to have a full t() in each of the else-if branches?
Merged
Merged
Member
|
@Valdnet do you want to take care of the manual rebase and fix the issues from the comments or close and started from scratch? |
Contributor
Author
|
@AndyScherzinger I'm closing PR 😉. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.