[stable27] fix: encode uri for trashbin delete#40642
Merged
Conversation
6 tasks
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
fix/noid/stable27-encode-uri-trashbin-restore
branch
from
a0463cf to
d280912
Compare
Merged
skjnldsv
approved these changes
Sep 27, 2023
ChristophWurst
approved these changes
Sep 27, 2023
kesselb
added
4. to release
susnux
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Similar to #40045 but different ;)
#is a valid character for our filenames but also for uris in general and therefore not encoded by default.To use
#in filenames we need to encode it.TODO
Checklist