Refactor OC\Server::getAvatarManager in user_ldap app#40206
Merged
skjnldsv merged 1 commit intonextcloud:masterfrom May 30, 2024
Merged
Conversation
summersab
force-pushed
the
refactor/apps/user_ldap/OC-Server-getAvatarManager
branch
from
3e79914 to
a4aa98a
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
approved these changes
May 30, 2024
Refactor `OC\Server::getAvatarManager` in user_ldap app (missed one) Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
skjnldsv
force-pushed
the
refactor/apps/user_ldap/OC-Server-getAvatarManager
branch
from
a4aa98a to
d62eb33
Compare
skjnldsv
requested review from
a team,
icewind1991,
sorbaugh and
yemkareems
and removed request for
a team
skjnldsv
added
3. to review
come-nc
approved these changes
May 30, 2024
skjnldsv
added
4. to release
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the deprecated method OC\Server::getAvatarManager and replaces it with OC\Server::get(\OCP\IAvatarManager::class) in the
user_ldapapp.Additionally, where necessary, the \OCP\IAvatarManager class is imported via the use directive.
This PR will be submitted once #40114 is approved.