Merged
Conversation
3cfb95e to
7cf9cdd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
Hum @nextcloud/files what do you think? |
come-nc
reviewed
Sep 14, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Merged
Valdnet
approved these changes
Aug 31, 2024
nfebe
approved these changes
Aug 31, 2024
Contributor
nfebe
left a comment
There was a problem hiding this comment.
Looks good, some capitalization suggestions. Thank you.
skjnldsv
approved these changes
Sep 3, 2024
Valdnet
approved these changes
Sep 4, 2024
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix drone Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix tests Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Co-authored-by: F. E Noel Nfebe <fenn25.fn@gmail.com> Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
c2c6030 to
78e09b5
Compare
Member
|
Sharding test error unrelated |
Member
Author
|
Worth a backport to 30 at least ? |
Member
|
/backport to stable30 |
Member
|
Agreed |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/40164/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f250643e f4aa2644 78e09b5a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/40164/stable30Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..ab511e8
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Contributor
|
If you manually backport, then please include: #40164 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ambiguous messages like :

Checklist