Refactor OC\Server::getCloudFederationFactory#40116
Merged
skjnldsv merged 2 commits intonextcloud:masterfrom Mar 15, 2024
Merged
Refactor OC\Server::getCloudFederationFactory#40116skjnldsv merged 2 commits intonextcloud:masterfrom
OC\Server::getCloudFederationFactory#40116skjnldsv merged 2 commits intonextcloud:masterfrom
Conversation
summersab
force-pushed
the
refactor/OC-Server-getCloudFederationFactory
branch
2 times, most recently
from
cfdec84 to
22a6781
Compare
Merged
skjnldsv
requested review from
a team,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
skjnldsv
approved these changes
Mar 15, 2024
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
skjnldsv
force-pushed
the
refactor/OC-Server-getCloudFederationFactory
branch
from
22a6781 to
1a5ec3d
Compare
nfebe
approved these changes
Mar 15, 2024
skjnldsv
added
4. to release
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the deprecated method
OC\Server::getCloudFederationFactoryand replaces it withOC\Server::get(\OCP\Federation\ICloudFederationFactory::class)throughout the entire NC codebase (excluding./appsand./3rdparty).Additionally, where necessary, the
OCP\Federation\ICloudFederationFactoryclass is imported via theusedirective.