Refactor OC\Server::getAppFetcher#40111
Conversation
49b8245 to
db4404b
Compare
|
So, I've never gotten this close to having a PR accepted by the NC team. I see everything is approved and passed, but I need to rebase. If I rebase, does that restart the approval process? |
|
I don't think we need a rebase yet, as this branch is not much behind master. The failure of cypress seems related to forks. I've seen the same one at #39243 and could not fix it. |
Well, I promised nickvergessen that I wouldn't make any new PRs or push code for the rest of the week, so I'll hold off on doing anything until I'm told. :-) |
|
If I convert to draft, will that prevent CI from being triggered if I push updates? |
|
Don't know, sorry. |
|
Thanks. I know that I became rather well-known in the past 24 hours, so I'd like to do what I can to prevent my newfound popularity from growing any further... |
Signed-off-by: Andrew Summers <[email protected]>
db4404b to
f461c79
Compare
This PR refactors the deprecated method
OC\Server::getAppFetcherand replaces it withOC\Server::get(\OC\App\AppStore\Fetcher\AppFetcher::class)throughout the entire NC codebase (excluding./appsand./3rdparty).Additionally, where necessary, the
\OC\App\AppStore\Fetcher\AppFetcherclass is imported via theusedirective.