enh(settings): Add and remove groups accessibly#40110
Merged
Conversation
4 tasks
1126756 to
9f913ed
Compare
Member
Author
Done! Also moved the actions next to the "Groups" navigation caption |
ShGKme
requested changes
Aug 30, 2023
Contributor
ShGKme
left a comment
There was a problem hiding this comment.
Works and looks good. But we should avoid using $children when possible.
9f913ed to
847f038
Compare
847f038 to
d09982e
Compare
d09982e to
630356b
Compare
ShGKme
approved these changes
Oct 10, 2023
630356b to
9e731d0
Compare
aaf6beb to
1965acb
Compare
marcoambrosini
approved these changes
Oct 11, 2023
JuliaKirschenheuter
approved these changes
Oct 11, 2023
ShGKme
approved these changes
Oct 11, 2023
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
1965acb to
4386803
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist