Replace custom input field with NcTextField#40043
Merged
JuliaKirschenheuter merged 1 commit intomasterfrom Aug 31, 2023
Merged
Conversation
ShGKme
reviewed
Aug 25, 2023
Contributor
ShGKme
left a comment
There was a problem hiding this comment.
Not really related to this PR, but should we also add aria-label and aria-haspopup to the emoji picker button here for a11y?
Contributor
Author
@ShGKme could you please open new NcVue issue regarding this? Thanks a lot! |
Contributor
A trigger button is not a part of Not sure about |
12ecdb1 to
a953b16
Compare
Pytal
reviewed
Aug 28, 2023
artonge
approved these changes
Aug 29, 2023
ShGKme
approved these changes
Aug 29, 2023
fc79503 to
abbe949
Compare
Pytal
reviewed
Aug 29, 2023
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
abbe949 to
381e3ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace custom input field with NcInputField
Checklist