pass the share to the cache instead of having to ask the storage#39944
Merged
icewind1991 merged 1 commit intomasterfrom Aug 28, 2023
Merged
pass the share to the cache instead of having to ask the storage#39944icewind1991 merged 1 commit intomasterfrom
icewind1991 merged 1 commit intomasterfrom
Conversation
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
nfebe
and removed request for
a team
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
share-cache-share
branch
from
bd7f46b to
df71b4d
Compare
AndyScherzinger
approved these changes
Aug 18, 2023
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
This was referenced Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going through the storage includes storage wrappers so it has a bit more overhead than you might expect.
A modest improvement for a small change