Refactor encryption app commands#39692
Conversation
1553fcb to
4507123
Compare
4507123 to
1b009e2
Compare
|
Conflicts resolved. |
nfebe
left a comment
There was a problem hiding this comment.
Please, rebase this against latest master.
1b009e2 to
881123f
Compare
Done. But it has already got out-of-dated. Should I rebase it again? |
|
@fsamapoor thanks, all good! I was hoping CI might get green if you rebase but no, it's fine. Just wait for other reviews. |
881123f to
ab2caed
Compare
|
@fenn-cs Cypress workflows are failing on almost all of my PRs. I don't know if there is anything that I can do to fix them. |
|
@fsamapoor Not to worry, those failures are unrelated (most likely as they are UI tests). |
ab2caed to
37bf803
Compare
|
Conflicts resolved. |
Thank you, please rebase. |
37bf803 to
a45dd55
Compare
Done. |
|
@fsamapoor now that this has another approval kindly, update/rebase it with master I would put my eyes on the jobs to get it in asap. Thank you! |
a45dd55 to
68da42a
Compare
Sure. Thank you! Other than Cypress workflows, I think there will be no issues. |
To improve code readability. Signed-off-by: Faraz Samapoor <fsa@adlas.at>
To improve code readability. Signed-off-by: Faraz Samapoor <fsa@adlas.at>
7899057 to
6b795da
Compare
Summary
I have made some adjustments to the
apps/encryption/lib/Commandclasses to improve the code readability.The improvements in this PR include but are not limited to:
Checklist