Raise default SMTP timeout from 10 to 30 sec#39638
Closed
Conversation
Signed-off-by: Git'Fellow <[email protected]>
Merged
skjnldsv
requested review from
a team,
ArtificialOwl,
ChristophWurst,
come-nc,
sorbaugh and
szaimen
and removed request for
a team and
ChristophWurst
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
approved these changes
Feb 24, 2024
| $stream = $transport->getStream(); | ||
| /** @psalm-suppress InternalMethod */ | ||
| $stream->setTimeout($this->config->getSystemValueInt('mail_smtptimeout', 10)); | ||
| $stream->setTimeout($this->config->getSystemValueInt('mail_smtptimeout', 30)); |
Member
There was a problem hiding this comment.
the downside is that server that are not reachable will make the PHP process run longer than 30 seconds and cause a timeout
I'm on the fence here. we could also improve our documentation about increasing the timeout if there are servers where this is necessary.
Contributor
There was a problem hiding this comment.
Yeah I would also vote against it, timeout can already be set in the configuration and 10 seconds looks like a sane default.
skjnldsv
added
enhancement
feature: emails
and removed
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With some hosted STMP services, like
smtp.office365.comthey have some security mesures like bruteforce protection, and SMTP response can take more than (default) 10s between SSL handshake, auth, EHLO, etc.. In the logs this can lead to things like:This PR raises the default from 10 to 30 seconds.
Other changes here are just small code optimizations.
Checklist