Make .devcontainer independent of processor architecture#39464
Closed
tsdicloud wants to merge 7 commits intonextcloud:masterfrom
Closed
Make .devcontainer independent of processor architecture#39464tsdicloud wants to merge 7 commits intonextcloud:masterfrom
tsdicloud wants to merge 7 commits intonextcloud:masterfrom
Conversation
szaimen
approved these changes
Jul 18, 2023
szaimen
requested review from
a team,
ArtificialOwl,
LukasReschke,
Pytal,
icewind1991,
nfebe and
susnux
and removed request for
a team
Pytal
approved these changes
Jul 18, 2023
susnux
approved these changes
Jul 18, 2023
tsdicloud
force-pushed
the
nmc/issues/39461-devcontainer-arm
branch
from
bb7c9e1 to
013c825
Compare
joshtrichards
requested changes
Sep 5, 2023
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Remove the personal/proprietary settings that don't belong in the PR.
Member
There was a problem hiding this comment.
This PR appears to include a bunch of unrelated changes. Was that intentional?
Member
There was a problem hiding this comment.
I'd say keep them as an example for custom setup, like separated here, which can be adapted by others
Member
There was a problem hiding this comment.
@tsdicloud feel free to remove the nmc specific files of course, since I would expect you wouldn't want them in the Nextcloud repo instead of just the nmc one
| # refresh .htaccess for short URL notation | ||
| sudo -u ${APACHE_RUN_USER} php occ maintenance:update:htaccess | ||
|
|
||
| # "Organisational" setting |
Member
There was a problem hiding this comment.
These look perhaps to be personal settings that I don't think belong in the PR
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed hardcoded amd64 architecture in install script within Dockerfile by an automatic architecture detection.
The containerization will now tear in packages for the detected architecture (if available), which makes Apple Silicone
working.
Checklist