Merged
Conversation
Signed-off-by: jld3103 <jld3103yt@gmail.com>
bigcat88
reviewed
Jul 11, 2023
Member
Author
|
@artonge @icewind1991 Can you help me with the CI failure? I don't see why my changes would cause any failure since they only add annotations which are completely ignored at runtime, thus no behavioral changes were made afaict |
artonge
approved these changes
Jul 12, 2023
Contributor
artonge
left a comment
There was a problem hiding this comment.
I think some of those tests are triggered only when some specific files are edited.
They might be failing for a long time 🙈 .
As your changes are mostly comments, I think we can merge without further concern.
If @icewind1991 agrees, feel free to merge :)
Member
Author
|
Yeah I already imagined something like that. There is no way the comments can break something |
bigcat88
approved these changes
Jul 12, 2023
Member
|
S3 external test fix is here: #39367 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From #36666. Adds the necessary annotations and descriptions.
Checklist