Add customer support link in the short footer#39291
Closed
aaygupta wants to merge 1 commit intonextcloud:masterfrom
aaygupta:feature/add-customer-support-link
Closed
Add customer support link in the short footer#39291aaygupta wants to merge 1 commit intonextcloud:masterfrom aaygupta:feature/add-customer-support-link
aaygupta wants to merge 1 commit intonextcloud:masterfrom
aaygupta:feature/add-customer-support-link
Conversation
Contributor
|
Hi @aaygupta 👋 Thanks for your great contribution 👍
|
kesselb
reviewed
Jul 10, 2023
Author
|
Hi @kesselb, all the mentioned changes have been made. Regards |
kesselb
approved these changes
Jul 11, 2023
Contributor
For the failing test. Could you pull in the latest changes from master and recompile the assets again? To have the latest changes. |
Signed-off-by: Ankit Gupta <[email protected]>
Author
|
Hi @kesselb I have rebased the branch. |
Merged
Merged
Altahrim
approved these changes
Mar 12, 2024
Contributor
|
Conflicts... |
Collaborator
|
@aaygupta Can you update the PR please? |
This was referenced Mar 14, 2024
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add customer support link in the short footer, add translations for en_GB, update tests.

TODO