Closed
Conversation
a253545 to
b4118da
Compare
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Member
Author
|
@skjnldsv This one is important and I need some help on the database migration. |
Member
|
Any chance this PR get's some love? |
e06a61d to
c4be207
Compare
The propertyvalue column can contain null 0x00 characters values because of serializing PHP objects since #30368. This truncates data in text fields, but not blob fields. We start by removing invalid value and altering the column to match the new type. That's what Sabre PDO's being doing in the first place 🙈 Closes #37754 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Match it to the value in oc_filecache table path column should be fine. Closes #9907 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
c4be207 to
1440e5a
Compare
Member
Author
|
For PostgreSQL : https://stackoverflow.com/questions/19300113/unable-to-convert-postgresql-text-column-to-bytea If we have less than 50k rows (value yet to determine), perform the migrations straight away. |
4 tasks
Member
Author
|
Fixed through #49528 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
propertyvaluefromTEXTtype toBLOBas it may contain null 0x00 characters because of php serialization DAV properties propertyvalue column has wrong column type #37754propertypathcolumn length Error reporting for too long filepaths (>255 chars) #9907If changing the type of the column can't be done, we'll need to create a new column and move data
TODO
Checklist