[stable27] fix(cypress): branch definition#39067
Merged
Conversation
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
3ca1585 to
772aa81
Compare
Member
Author
|
/backport to stable26 |
Member
Author
|
/backport to master |
Member
Author
Antreesy
approved these changes
Jun 29, 2023
Contributor
There was a problem hiding this comment.
🦭
Seems to work! +1
Saw that also in my backport: https://github.com/nextcloud/server/actions/runs/5409725309/jobs/9833992543?pr=39055#step:5:146
Let's see if it will help
Member
Author
This is a different issue :) |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
5ec1434 to
16c7c07
Compare
Pytal
approved these changes
Jun 29, 2023
Member
Author
Maybe not, let's see |
Member
Author
This comment was marked as resolved.
This comment was marked as resolved.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
Explanation
The trick is that
github.base_refis only set when the workflow was triggered by apull_requestand it contains the value of the source branch of the PR.github.ref_namewill than only be used if the workflow was not triggered by apull_requestand it also just contains the branch name.GitHub Documentation
Detailed explanation from official GitHub docs: